Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ed25519 auth support #791

Merged
merged 1 commit into from Jul 17, 2020
Merged

Add ed25519 auth support #791

merged 1 commit into from Jul 17, 2020

Conversation

dciabrin
Copy link
Contributor

Initial support for #786 based on PyNaCl. Currently, authentication is
limited to 32bytes-long passwords.

@dciabrin dciabrin mentioned this pull request Apr 17, 2019
Closed
4 tasks
@dciabrin
Copy link
Contributor Author

The test that I've added for ed25519 authentication has been run for the MySQL 8.0 build job. I'll rework the review to only trigger that test when using Mariadb 10.3+

@dciabrin
Copy link
Contributor Author

dciabrin commented Jun 4, 2019

This new version is provides a full support for ed25519 auth mechanism, that depends on latest PyNaCl.
PyNaCl has committed pyca/pynacl#528 which I'm using in this review, however they have not yet made a new release for it.

I've tried to configure travis to let pip download from git source, however this is slower and doesn't work with pip 9.0.1, which makes job #1327.3 fail.

Let's wait for a new PyNaCl release and I'll update this PR to "pip install PyNaCl" directly.

@dciabrin dciabrin mentioned this pull request Jan 15, 2020
Closed
dciabrin added a commit to dciabrin/python-PyMySQL that referenced this pull request Mar 27, 2020
@dciabrin
Add support for mariadb's auth_ed25519
7b2d69f 
Include #791 [1] into the current release of PyMySQL to
support mariadb's auth_ed25519.

This patch can be dropped once the PR have landed upstream
(currently depending on a new release of pynacl).

[1] PyMySQL/PyMySQL#791

Related-Bug: #1868454
dciabrin added a commit to dciabrin/python-PyMySQL that referenced this pull request Mar 30, 2020
@dciabrin
Add support for mariadb's auth_ed25519
7314b9d 
Include #791 [1] into the current release of PyMySQL to
support mariadb's auth_ed25519.

This patch can be dropped once the PR have landed upstream
(currently depending on a new release of pynacl).

[1] PyMySQL/PyMySQL#791

Related-Bug: #1868454
@dciabrin dciabrin mentioned this pull request Mar 31, 2020
Open
amoralej pushed a commit to rdo-common/python-PyMySQL that referenced this pull request Apr 6, 2020
@dciabrin @amoralej
Add support for mariadb's auth_ed25519
31de31a 
Include #791 [1] into the current release of PyMySQL to
support mariadb's auth_ed25519.

This patch can be dropped once the PR have landed upstream
(currently depending on a new release of pynacl).

[1] PyMySQL/PyMySQL#791

Related-Bug: #1868454
@dciabrin
Copy link
Contributor Author

PyNaCl 1.4.0 has just been released [1], so I'm rebasing the previous commit to consume it in CI.
Authenticating with auth_ed25519 works whatever the password length, and it looks like Travis is passing now.

[1] pyca/pynacl#573 (comment)

@dciabrin
Copy link
Contributor Author

@methane any chance you can have a look at this rebase? All automated tests are green now.

@methane methane merged commit 73f9770 into PyMySQL:master Jul 17, 2020
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dciabrin @methane