Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rust crate to be placed outside of the directory containing pyproject.toml #1346

Closed
messense opened this issue Dec 9, 2022 · 0 comments · Fixed by #1347
Closed

Allow Rust crate to be placed outside of the directory containing pyproject.toml #1346

messense opened this issue Dec 9, 2022 · 0 comments · Fixed by #1347
Labels
enhancement New feature or request sdist Source distribution

Comments

@messense
Copy link
Member

messense commented Dec 9, 2022

Lifting the two limitations in

  1. bail!("Cargo.toml can not be placed outside of the directory containing pyproject.toml");
  2. bail!(
    "pyproject.toml was not included by `cargo package`. \
    Please make sure pyproject.toml is not excluded or build without `--sdist`"
    )

It'd be useful for projects using the cffi bindings, to have the c-abi crate and python bindings separated, for example

py/
  pyproject.toml
cabi/
  Cargo.toml
@messense messense added enhancement New feature or request sdist Source distribution labels Dec 9, 2022
bors bot added a commit that referenced this issue Dec 12, 2022
1347: Allow Rust crate to be placed outside of the directory containing `pyproject.toml` r=messense a=messense

Closes #1346 

Co-authored-by: messense <messense@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sdist Source distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant