Consider pyproject.toml features when detecting pyo3 #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks! Please add a changelog entry. |
Consider the cargo options merged from the pyproject.toml when generating the cargo metadata. This fixes the following problem: if pyo3 is an optional dependency that is enabled through a feature declared in pyproject.toml, then maturin will not detect pyo3 as binding.
daniestevez
force-pushed
the
cargo_options
branch
from
27dcef0
to
71f7825
Compare
|
Thank you for your fast response. I've force-pushed to include the changelog entry. |
2 tasks
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Aug 8, 2022
https://build.opensuse.org/request/show/991319 by user mia + dimstar_suse - Update to v0.13.1 * Add 64-bit RISC-V support gh#PyO3/maturin#1001 * Run tests on CI with cargo-nextest gh#PyO3/maturin#1004 * Add support for invoking with python3 -m maturin gh#PyO3/maturin#1008 * Consider pyproject.toml features when detecting pyo3 gh#PyO3/maturin#1014 * Respect user specified Rust target in maturin develop gh#PyO3/maturin#1016 * Use cargo rustc --crate-type cdylib on Rust nightly/dev channel gh#PyO3/maturin#1020 * Use cargo-nextest in test-alpine gh#PyO3/maturin#1021 - Update to v0.13.0 * Drop python 3.6 by @konstin in #945 * Add support for building with multiple binary targets by @messense in #948 * Add a --target option to maturin list-python command by @messense in #957 * Add support for using bundled pyth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a mixed python/Rust project which uses PyO3. PyO3 is declared as an optional dependency of our crate, which gets enabled with a feature
python. This allows us to build the crate as a Rust-only library as well.Starting with maturin 0.13.0 (and also in the master branch), we have noticed that maturin does no longer detect pyo3, so it tries to use CFFI bindings rather than pyo3 bindings. With maturin <0.13 we were using
cargo-extra-argsinpyproject.toml, and with maturin >=0.13 we have switched this tofeatures(also inpyproject.toml).This repository demonstrates this.
Looking at the code, we think that the problem is that the features enabled in
pyproject.tomlare not merged when obtaining the cargo metadata to produce the dependency graph.