Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workspace.members in Cargo.toml from sdist if there isn't any path dependency #1227

Merged
merged 2 commits into from
Oct 30, 2022

Conversation

messense
Copy link
Member

Fixes #1226

@messense messense added the sdist Source distribution label Oct 30, 2022
@netlify
Copy link

netlify bot commented Oct 30, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 6037298
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/635e377fd5d1e7000973cec8
😎 Deploy Preview https://deploy-preview-1227--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense force-pushed the workspace-members branch 4 times, most recently from 0d18bda to 6074445 Compare October 30, 2022 07:42
@messense messense force-pushed the workspace-members branch 2 times, most recently from a63574f to a1470f7 Compare October 30, 2022 08:26
Otherwise `cargo package --list --allow-dirty` outputs both `README.md` and `Readme.md`

```
Cargo.toml
Cargo.toml.orig
LICENSE
README.md
Readme.md
check_installed/check_installed.py
pyo3_pure.pyi
pyproject.toml
src/lib.rs
tests/test_pyo3_pure.py
tox.ini
```
@messense messense merged commit 2ec3f96 into PyO3:main Oct 30, 2022
@messense messense deleted the workspace-members branch October 30, 2022 09:07
@messense messense added this to the 0.14.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdist Source distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maturin keeps [workspace] table in Cargo.toml but doesn't include actual workspace directories in sdist
1 participant