Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic tags when sys.implementation.name != platform.python_implementation() #1232

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Use generic tags when sys.implementation.name != platform.python_implementation() #1232

merged 2 commits into from
Nov 1, 2022

Conversation

messense
Copy link
Member

@messense messense commented Nov 1, 2022

Closes #1230

@netlify
Copy link

netlify bot commented Nov 1, 2022 •
edited
Loading

✅ Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit e4b9ce1
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6360d092cdb57c0008b439b6
😎 Deploy Preview https://deploy-preview-1232--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense mentioned this pull request Nov 1, 2022
Closed
@messense messense added the wheel Wheel label Nov 1, 2022
messense
messense commented Nov 1, 2022
View reviewed changes
src/python_interpreter/mod.rs
/// Comes from `sys.platform.name`
pub implmentation_name: String,
/// Comes from sysconfig var `SOABI`
pub soabi: Option<String>,
Copy link
Member Author

@messense messense Nov 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally implmentation_name and soabi should be moved to InterpreterConfig and abi_tag should changed to derive from soabi in Rust instead, but that requires updating all of the bundled sysconfig files, we can do that later.

@messense
Copy link
Member Author

messense commented Nov 1, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 1, 2022

Build succeeded:

@bors bors bot merged commit 1924bcd into PyO3:main Nov 1, 2022
@messense messense deleted the pyston branch November 1, 2022 10:13
@messense
Copy link
Member Author

messense commented Nov 1, 2022 

FAIL [  17.167s] maturin::run develop_pyo3_ffi_pure
FAIL [  56.923s] maturin::run develop_pyo3_pure
FAIL [  11.939s] maturin::run editable_pyo3_ffi_pure
FAIL [  46.915s] maturin::run editable_pyo3_pure
FAIL [  13.128s] maturin::run integration_pyo3_ffi_pure
FAIL [  43.587s] maturin::run integration_pyo3_pure

Note: All of the abi3 wheel build tests failed on Pyston since it does have support for stable abi yet.

This was referenced Nov 2, 2022
Merged
Merged
bors bot added a commit that referenced this pull request Nov 2, 2022
@bors @messense
Merge #1241
30c641c 
1241: CI: Add Pyston test job r=messense a=messense

Regression test for #1232

Co-authored-by: messense <messense@icloud.com>
@messense messense added this to the 0.14.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wheel Wheel
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

support alternative implementations of CPython API
1 participant
@messense