Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SOURCE_DATE_EPOCH environment variable in wheel building #1334

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Support SOURCE_DATE_EPOCH environment variable in wheel building #1334

merged 1 commit into from
Dec 6, 2022

Conversation

zmanji
Copy link
Contributor

@zmanji zmanji commented Dec 5, 2022

This adds support for the SOURCE_DATE_EPOCH environment variable like wheel does when building wheels. If this environment variable is set, the mtime of the files in the wheel are set to this value to ensure reproducible output.

Fixes #1320

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 15f8045
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/638e1eba6551da00085b9286
😎 Deploy Preview https://deploy-preview-1334--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense added this to the 1.0.0 milestone Dec 5, 2022
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you please fix the clippy warnings and add a changelog entry in Changelog.md?

src/module_writer.rs Outdated Show resolved Hide resolved
src/module_writer.rs Show resolved Hide resolved
This adds support for the `SOURCE_DATE_EPOCH` environment variable like wheel
does when building wheels. If this environment variable is set, the `mtime` of
the files in the wheel are set to this value to ensure reproducible output.

Fixes #1320
@zmanji
Copy link
Contributor Author

zmanji commented Dec 5, 2022

Thanks for the PR! Could you please fix the clippy warnings and add a changelog entry in Changelog.md?

This should be done now.

Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+ p=1

@bors
Copy link
Contributor

bors bot commented Dec 6, 2022

@bors bors bot merged commit 37c62f6 into PyO3:main Dec 6, 2022
@messense
Copy link
Member

messense commented Dec 8, 2022

Released in v0.14.5.

@zmanji zmanji deleted the enable-source-date-epoch branch December 8, 2022 15:13
@messense messense removed this from the 1.0.0 milestone Dec 13, 2022
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Dec 13, 2022
https://build.opensuse.org/request/show/1042453
by user mia + dimstar_suse
- Manually override outdated ahash dependency of chumsky crate
  in vendor tarball to hopefully facilitate reproducible builds
  Adds vendor-update-ahash-dependency.patch
  boo#1206342
- Update to v0.14.5:
  * Support SOURCE_DATE_EPOCH environment variable in wheel building
    gh#PyO3/maturin#1334
  * Fix sdist when all Cargo workspace members are excluded
    gh#PyO3/maturin#1343
- Changes in v0.14.4:
  * Bump sigstore/gh-action-sigstore-python from 0.0.11 to 0.1.0
    gh#PyO3/maturin#1317
  * Refactor Target::get_platform_tag to use standard osname-release-machine fallback representation
    gh#PyO3/maturin#1318
  * Better error message when upload failed with status code 403
    gh#PyO3/maturin#1323
  * Warn about patchelf version requirement
    gh#PyO3/maturin#1327
  * Refactor compil
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 8, 2023
https://build.opensuse.org/request/show/1085456
by user mia + dimstar_suse
- Update to v0.15.1:
  * Use shlex to split MATURIN_SETUP_ARGS
    gh#PyO3/maturin#1595
  * Fix finding interpreters from bundled sysconfigs
    gh#PyO3/maturin#1598
- Changes in v0.15.0:
  * Feature gate zig and xwin based cross compiling
    gh#PyO3/maturin#1324
  * Feature gate maturin new and maturin init commands
    gh#PyO3/maturin#1330
  * Build with --no-default-features
    gh#PyO3/maturin#1333
  * Support SOURCE_DATE_EPOCH environment variable in wheel
    building
    gh#PyO3/maturin#1334
  * Remove deprecated config options
    gh#PyO3/maturin#1335
  * cargo deny multiple crate versions
    gh#PyO3/maturin#1336
  * Replace rpassword with dialoguer
    gh#PyO3/maturin#1338
  * Fix sdist when all Cargo workspace members are excluded
    gh#PyO3/maturin#1343
  * Update normpath to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SOURCE_DATE_EPOCH environment variable to set mtime of files in wheel
2 participants