Pre commit #1763
Pre commit #1763
Conversation
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
.pre-commit-config.yaml
Outdated
| language: system | ||
| pass_filenames: false | ||
| # rustup component add clippy | ||
| - id: cargo-clippy |
There was a problem hiding this comment.
I don't think we should add cargo check and cargo clippy in pre-commit hooks because they may take a long time which makes the git commit UX bad.
There was a problem hiding this comment.
I was able to set these checks to run only for the 'manual' stage which means only when pre-commit is run with pre-commit run --hook-stage manual --all.
It's debatable whether another task runner like makefile, cargo make or just would be easier to use for this, but at least pre-commit is able to serve as a commit hook and also as a way to fairly easily run all the checks at once with a single tool.
|
FYI, I've also set up pre-commit.ci for this repo. |
maturin has various checks that run on the CI so it would be helpful for contributors if they could easily run the same checks locally so they can find out if there is a problem before their code reaches the CI.
pre-commit is a tool used by many projects to run checks before every commit (and can also be run manually with
pre-commit run --all)