Keep trailing newlines from templates #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
nils-werner
changed the title
Don't run |
nils-werner
force-pushed
the
trailing-newline
branch
from
630555b
to
759f85e
Compare
Ah, thanks! I've force-pushed an amendment to get rid of the mess. |
nils-werner
force-pushed
the
trailing-newline
branch
from
759f85e
to
95ee7b5
Compare
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 7, 2023
https://build.opensuse.org/request/show/1123696 by user mia + anag+factory - Update to 1.3.1 * Use external uniffi-bindgen if no root package is configured gh#PyO3/maturin#1797 * Add trusted publishing section to the user guide gh#PyO3/maturin#1800 * Fix wheel filename for GraalPy gh#PyO3/maturin#1802 * Pytest skeleton in mixed template gh#PyO3/maturin#1807 * Keep trailing newlines from templates gh#PyO3/maturin#1808 * Bump rustix from 0.37.23 to 0.37.25 gh#PyO3/maturin#1809 * Auto detect Python 3.13 gh#PyO3/maturin#1810 * Fix missing workspace.members in sdist gh#PyO3/maturin#1811 * Don't set MACOSX_DEPLOYMENT_TARGET for editable builds gh#PyO3/maturin#1815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both rustfmt and pycodestyle/PEP8 require a trailing newline in code files. These newlines are produced by most code editors and are there in the code templates, however
minijinjais configured to remove any trailing newlines. This means maturin produces templates that don't adhere to the code styles in both Rust an Python.This PR
minijinjarequirement to1.0.7(that's when the option was introduced)Environment::set_keep_trailing_newline(true)I'm relatively new to Rust and Cargo, and I am a bit worried by the massive change in
Cargo.lock. Is this supposed to happen, or did I do something wrong?