Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass no_deps to cargo metadata #2083

Closed
wants to merge 1 commit into from
Closed

Pass no_deps to cargo metadata #2083

wants to merge 1 commit into from

Conversation

orf
Copy link

@orf orf commented May 11, 2024

I've been trying to debug slow CI builds using Maturin.

On my Linux builds, calling cargo metadata appears to cause the entire project to be built. If you're using sccache then this suddenly becomes very slow.

2024-05-11T17:16:58.211839Z DEBUG maturin::project_layout: Resolving cargo metadata from "/__w/pyvector/pyvector/Cargo.toml"
    Updating crates.io index
    Updating git repository `[https://github.com/vectordotdev/vector.git`](https://github.com/vectordotdev/vector.git%60)
    Updating git repository `[https://github.com/vectordotdev/heim.git`](https://github.com/vectordotdev/heim.git%60)
    Updating git repository `[https://github.com/tokio-rs/tracing`](https://github.com/tokio-rs/tracing%60)
 Downloading crates ...
  Downloaded adler v1.0.2
  Downloaded aead v0.5.2
  Downloaded RustyXML v0.3.0
  Downloaded ahash v0.8.11

Passing --no-deps to cargo metadata does not cause a build. Do we need the dependency information?

Copy link

netlify bot commented May 11, 2024

Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e04a043
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/663fac691962b50008347225
😎 Deploy Preview https://deploy-preview-2083--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@messense
Copy link
Member

It was just download dependencies, we need the depgraph to correctly detect bindings.

@messense messense closed this May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants