Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Trove classifiers #48

Merged
merged 3 commits into from
Dec 15, 2018
Merged

Support Trove classifiers #48

merged 3 commits into from
Dec 15, 2018

Conversation

ijl
Copy link
Contributor

@ijl ijl commented Dec 14, 2018

Fixes #32.

@konstin
Copy link
Member

konstin commented Dec 15, 2018

Thank you!

Could you remove the second metadata? So that instead of

[package.metadata.pyo3-pack.scripts]
ph = "pyo3_pack:print_hello"

[package.metadata.pyo3-pack.metadata]
classifier = ["Programming Language :: Python"]

we have

[package.metadata.pyo3-pack.scripts]
ph = "pyo3_pack:print_hello"

[package.metadata.pyo3-pack]
classifier = ["Programming Language :: Python"]

@ijl
Copy link
Contributor Author

ijl commented Dec 15, 2018

Ok, done. If you merge, could you tag a release as well?

@konstin konstin merged commit d725eef into PyO3:master Dec 15, 2018
@konstin
Copy link
Member

konstin commented Dec 15, 2018

Thank you! I've tagged a release and the ci should publish it to pypi and github releases soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants