Add PEP 656 musllinux support #543
Conversation
src/auditwheel/manylinux.rs
Outdated
| @@ -3,7 +3,7 @@ use serde::{Deserialize, Serialize}; | |||
| use std::fmt; | |||
| use std::str::FromStr; | |||
|
|
|||
| /// Decides how to handle manylinux compliance | |||
| /// Decides how to handle manylinux and musllinux compliance | |||
| #[derive(Serialize, Deserialize, Debug, Clone, Eq, PartialEq, Copy)] | |||
| pub enum Manylinux { | |||
There was a problem hiding this comment.
I'm considering rename this struct to something like Platform/PlatformTag, what do you think? @konstin
There was a problem hiding this comment.
The --manylinux command line option also needs some tweaking.
There was a problem hiding this comment.
Difficult question. I worry that having both --target and --platform will be confusing to people, esp. since platform gets. Maybe something like --compatibility? --tag would be another possibility, but "tag" does sound more like metadata (e.g. docker tag) than like libc flavor and version.
This comment has been minimized.
This comment has been minimized.
| case_insensitive = true, | ||
| name = "compatibility", | ||
| long = "compatibility", | ||
| alias = "manylinux", |
There was a problem hiding this comment.
Let's keep the --manylinux as an alias to --compatibility for a while. It'd be nice to somehow emit a warning if --manylinux is used instead of --compatibility.
Closes #542