Switch to ureq and some refactorings #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ureq has significantly less dependencies and thereby compiles faster
|
✔️ Deploy Preview for maturin-guide canceled. 🔨 Explore the source changes: 7a557dd 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/61d9670c21028600079664e8 |
|
https://github.com/PyO3/maturin/runs/4751697023?check_suite_focus=true Looks like we still need to provide a way to disable rustls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is for switching from reqwest to ureq which has a lot less dependencies and therefore compiles faster.
The second commit was an attempt to take the even further that kinda failed (no significant compile time improvements) but I refactored auditwheel and upload into a better module structure: Nearly all auditwheel logic is now in the
auditwheelmodule and I removed registry.rs and merged it into upload.rs