Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use python interpreters from bundled sysconfig when not cross compiling #907

Merged
merged 1 commit into from
May 9, 2022

Conversation

messense
Copy link
Member

@messense messense commented May 9, 2022

If cross compiling works, native build should work too.

@netlify
Copy link

netlify bot commented May 9, 2022

Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 6b8858f
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/6278d5e699f7e10008864f97
😎 Deploy Preview https://deploy-preview-907--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense messense merged commit aedee8f into PyO3:main May 9, 2022
@messense messense deleted the native-sysconfig branch May 9, 2022 13:14
@konstin
Copy link
Member

konstin commented May 9, 2022

What do you think about making some kind of flag/option to prefer the bundled config over locally installed interpreter? I'd expect that the bundled ones would be a bit faster because we avoid pulling external stuff in, they should also work better with cargo's caching (currently sometimes get confused and recompiles stuff because pycharm's launcher's and my terminal's environment are slightly different) and probably also more stable because we don't have to deal with broken/weird python installations.

@messense
Copy link
Member Author

I thought about doing that once we switch to --find-interpreter. #796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants