Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building bin bindings wheels with multiple platform tags #928

Merged
merged 2 commits into from
May 21, 2022

Conversation

messense
Copy link
Member

@messense messense commented May 19, 2022

This allows maturin build --manylinux manylinux_x_y musllinux_x_y -b bin while disallows any other forms of multiple platform tags. (Which is the old behavior before this change).

Closes #927

@netlify
Copy link

netlify bot commented May 19, 2022

‼️ Deploy request for maturin-guide rejected.

Name Link
🔨 Latest commit a7286df

eprintln!("⚠️ Warning: manylinux1 is unsupported by the Rust compiler.");
}

match bridge {
BridgeModel::Bin => {
// Only support two different kind of platform tags when compiling to musl target
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can lift this limitation if we want to in the future.

@messense messense marked this pull request as ready for review May 19, 2022 12:52
@konstin
Copy link
Member

konstin commented May 19, 2022

i wonder if it makes sense to have a staticlinux or similar tag which automatically gets tagged with both just like universal2. that way we could keep the single argument logic internally

@messense
Copy link
Member Author

i wonder if it makes sense to have a staticlinux or similar tag which automatically gets tagged with both just like universal2

I think people are more familiar with the standard manylinux/musllinux tags, a staticlinux tag diverges from the standard.

that way we could keep the single argument logic internally

I was thinking about lift the limitation of single platform tags in the future. It's fine to tag a wheel with multiple manylinux/musllinux tags as long as they're audited.

@messense messense merged commit f71f5ef into PyO3:main May 21, 2022
@messense messense deleted the multiple-platform-tags branch May 21, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for combined manylinux and musllinux platform tags for bin bindings
2 participants