Fix Windows Store install detection #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Windows versions refuse to see the Windows Store application aliases unless you explicitly append the ".exe" extension.
Some weird or broken installs can be reported by py.exe. We shouldn't fail to run just because of these installs as others could exist that work.
✅ Deploy Preview for maturin-guide canceled.Built without sensitive environment variables
|
messense
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two fixes:
maturinwas unable to runpythonexecutables for auto-detection without the.exeextension explicitly added, so this adds the extension.py.exethat can pick up all of my Windows Store installs. My Python 3.7 install is unable to be run throughpy.exefor whatever reason, however. There is no reason that I can see to completely bail when we can't execute the test command throughpy.exefor a particular install, so I changed it to just a warning.Prior work #944
Completely fixes #788