Allow dictionary content control via keyword list #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update README.md on how to customize your dictionary - Make macro invoke itself recursively to control what is added to the dictionary
althonos
reviewed
Mar 24, 2022
| pyo3_built!{$py, $info, "build", "time", "deps", "features", "host", "target"} | ||
| }; | ||
| // Custom build | ||
| ($py: ident, $info: ident, $($i:tt ),+ ) => {{ |
There was a problem hiding this comment.
Can you check if making $i a literal instead of a token-tree here would work? This could help debugging.
Remove "intro" and "finish" identifiers and inline their contents in the custom build pattern
|
Thank you all for the review! I followed @adamreichold advice and inlined the "into" and "finish" code in the custom build pattern. @althonos I didn't manage to make things work with the |
|
Okay I tried what I had in mind and it didn't work so I'll merge the way it is. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow macro users to control the content of the build dict if they want to.
Default macro usage is not affected (backward compatibility).
Changes (from commit):
dictionary