Merge pull request #3391 from alex/drop-trait

Remove usage of `AsPyPointer` in traits for convergint to PyObject
PyO3 · Aug 16, 2023 · 0375d57 · 0375d57
2 parents 75da891 + c259e77
commit 0375d57
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/newsfragments/3391.changed.md b/newsfragments/3391.changed.md
@@ -0,0 +1 @@
+Replace `AsPyPointer` with `AsRef<PyAny>` as a bound in the blanket implementation of `From<&T> for PyObject`
diff --git a/src/instance.rs b/src/instance.rs
@@ -933,12 +933,18 @@ impl<T> crate::AsPyPointer for Py<T> {
     }
 }
 
+impl std::convert::From<&'_ PyAny> for PyObject {
+    fn from(obj: &PyAny) -> Self {
+        unsafe { Py::from_borrowed_ptr(obj.py(), obj.as_ptr()) }
+    }
+}
+
 impl<T> std::convert::From<&'_ T> for PyObject
 where
-    T: AsPyPointer + PyNativeType,
+    T: PyNativeType + AsRef<PyAny>,
 {
     fn from(obj: &T) -> Self {
-        unsafe { Py::from_borrowed_ptr(obj.py(), obj.as_ptr()) }
+        unsafe { Py::from_borrowed_ptr(obj.py(), obj.as_ref().as_ptr()) }
     }
 }