Enable lint: ignored_unit_patterns

PyO3 · Apr 25, 2024 · 989257c · 989257c
1 parent a191d01
commit 989257c
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/src/impl_/extract_argument.rs b/src/impl_/extract_argument.rs
@@ -32,7 +32,7 @@ where
     type Holder = ();
 
     #[inline]
-    fn extract(obj: &'a Bound<'py, PyAny>, _: &'a mut ()) -> PyResult<Self> {
+    fn extract(obj: &'a Bound<'py, PyAny>, (): &'a mut ()) -> PyResult<Self> {
         obj.extract()
     }
 }
@@ -50,7 +50,7 @@ impl<'a, 'py, T: 'py + PyTypeCheck> PyFunctionArgument<'a, 'py> for Option<&'a B
     type Holder = ();
 
     #[inline]
-    fn extract(obj: &'a Bound<'py, PyAny>, _: &'a mut ()) -> PyResult<Self> {
+    fn extract(obj: &'a Bound<'py, PyAny>, (): &'a mut ()) -> PyResult<Self> {
         if obj.is_none() {
             Ok(None)
         } else {

diff --git a/src/lib.rs b/src/lib.rs
@@ -20,6 +20,7 @@
     )
 )))]
 #![deny(
+    clippy::ignored_unit_patterns,
     clippy::implicit_clone,
     clippy::inefficient_to_string,
     clippy::map_unwrap_or,

diff --git a/src/pycell.rs b/src/pycell.rs
@@ -404,7 +404,7 @@ impl<T: PyClass> PyCell<T> {
         self.0
             .borrow_checker()
             .try_borrow_unguarded()
-            .map(|_: ()| &*self.0.get_ptr())
+            .map(|()| &*self.0.get_ptr())
     }
 
     /// Provide an immutable borrow of the value `T` without acquiring the GIL.
@@ -662,15 +662,15 @@ impl<'py, T: PyClass> PyRef<'py, T> {
         cell.ensure_threadsafe();
         cell.borrow_checker()
             .try_borrow()
-            .map(|_| Self { inner: obj.clone() })
+            .map(|()| Self { inner: obj.clone() })
     }
 
     pub(crate) fn try_borrow_threadsafe(obj: &Bound<'py, T>) -> Result<Self, PyBorrowError> {
         let cell = obj.get_class_object();
         cell.check_threadsafe()?;
         cell.borrow_checker()
             .try_borrow()
-            .map(|_| Self { inner: obj.clone() })
+            .map(|()| Self { inner: obj.clone() })
     }
 }
 
@@ -859,7 +859,7 @@ impl<'py, T: PyClass<Frozen = False>> PyRefMut<'py, T> {
         cell.ensure_threadsafe();
         cell.borrow_checker()
             .try_borrow_mut()
-            .map(|_| Self { inner: obj.clone() })
+            .map(|()| Self { inner: obj.clone() })
     }
 }
 

diff --git a/src/types/bytearray.rs b/src/types/bytearray.rs
@@ -99,7 +99,7 @@ impl PyByteArray {
             std::ptr::write_bytes(buffer, 0u8, len);
             // (Further) Initialise the bytearray in init
             // If init returns an Err, pypybytearray will automatically deallocate the buffer
-            init(std::slice::from_raw_parts_mut(buffer, len)).map(|_| pybytearray)
+            init(std::slice::from_raw_parts_mut(buffer, len)).map(|()| pybytearray)
         }
     }
 

diff --git a/src/types/bytes.rs b/src/types/bytes.rs
@@ -95,7 +95,7 @@ impl PyBytes {
             std::ptr::write_bytes(buffer, 0u8, len);
             // (Further) Initialise the bytestring in init
             // If init returns an Err, pypybytearray will automatically deallocate the buffer
-            init(std::slice::from_raw_parts_mut(buffer, len)).map(|_| pybytes)
+            init(std::slice::from_raw_parts_mut(buffer, len)).map(|()| pybytes)
         }
     }