Merge pull request #357 from chr1sj0nes/master

Add `PyList.sort()`.
PyO3 · Feb 17, 2019 · 9ceb453 · 9ceb453
2 parents 61194ab + 275e6cb
commit 9ceb453
Showing 1 changed file with 22 additions and 0 deletions.
diff --git a/src/types/list.rs b/src/types/list.rs
@@ -111,6 +111,11 @@ impl PyList {
             index: 0,
         }
     }
+
+    /// Sorts the list in-place. Equivalent to python `l.sort()`
+    pub fn sort(&self) -> PyResult<()> {
+        unsafe { err::error_on_minusone(self.py(), ffi::PyList_Sort(self.as_ptr())) }
+    }
 }
 
 /// Used by `PyList::iter()`.
@@ -372,4 +377,21 @@ mod test {
         let v2 = list.as_ref().extract::<Vec<i32>>().unwrap();
         assert_eq!(v, v2);
     }
+
+    #[test]
+    fn test_sort() {
+        let gil = Python::acquire_gil();
+        let py = gil.python();
+        let v = vec![7, 3, 2, 5];
+        let list = PyList::new(py, &v);
+        assert_eq!(7, list.get_item(0).extract::<i32>().unwrap());
+        assert_eq!(3, list.get_item(1).extract::<i32>().unwrap());
+        assert_eq!(2, list.get_item(2).extract::<i32>().unwrap());
+        assert_eq!(5, list.get_item(3).extract::<i32>().unwrap());
+        list.sort().unwrap();
+        assert_eq!(2, list.get_item(0).extract::<i32>().unwrap());
+        assert_eq!(3, list.get_item(1).extract::<i32>().unwrap());
+        assert_eq!(5, list.get_item(2).extract::<i32>().unwrap());
+        assert_eq!(7, list.get_item(3).extract::<i32>().unwrap());
+    }
 }