Merge pull request #3767 from Icxolu/complex

implement `PyComplexMethods`
PyO3 · Jan 27, 2024 · ed7263f · ed7263f
2 parents 796e419 + 37e2a4d
commit ed7263f
Show file tree

Hide file tree

Showing 4 changed files with 190 additions and 78 deletions.
diff --git a/guide/src/class/numeric.md b/guide/src/class/numeric.md
@@ -170,8 +170,8 @@ impl Number {
         self.0 as f64
     }
 
-    fn __complex__<'py>(&self, py: Python<'py>) -> &'py PyComplex {
-        PyComplex::from_doubles(py, self.0 as f64, 0.0)
+    fn __complex__<'py>(&self, py: Python<'py>) -> Bound<'py, PyComplex> {
+        PyComplex::from_doubles_bound(py, self.0 as f64, 0.0)
     }
 }
 ```
@@ -321,8 +321,8 @@ impl Number {
         self.0 as f64
     }
 
-    fn __complex__<'py>(&self, py: Python<'py>) -> &'py PyComplex {
-        PyComplex::from_doubles(py, self.0 as f64, 0.0)
+    fn __complex__<'py>(&self, py: Python<'py>) -> Bound<'py, PyComplex> {
+        PyComplex::from_doubles_bound(py, self.0 as f64, 0.0)
     }
 }
 

diff --git a/src/conversions/num_complex.rs b/src/conversions/num_complex.rs
@@ -59,10 +59,10 @@
 //! #
 //! #         module.add_function(wrap_pyfunction!(get_eigenvalues, module)?)?;
 //! #
-//! #         let m11 = PyComplex::from_doubles(py, 0_f64, -1_f64);
-//! #         let m12 = PyComplex::from_doubles(py, 1_f64, 0_f64);
-//! #         let m21 = PyComplex::from_doubles(py, 2_f64, -1_f64);
-//! #         let m22 = PyComplex::from_doubles(py, -1_f64, 0_f64);
+//! #         let m11 = PyComplex::from_doubles_bound(py, 0_f64, -1_f64);
+//! #         let m12 = PyComplex::from_doubles_bound(py, 1_f64, 0_f64);
+//! #         let m21 = PyComplex::from_doubles_bound(py, 2_f64, -1_f64);
+//! #         let m22 = PyComplex::from_doubles_bound(py, -1_f64, 0_f64);
 //! #
 //! #         let result = module
 //! #             .getattr("get_eigenvalues")?

diff --git a/src/tests/hygiene/pymethods.rs b/src/tests/hygiene/pymethods.rs
@@ -281,8 +281,11 @@ impl Dummy {
         slf
     }
 
-    fn __complex__<'py>(&self, py: crate::Python<'py>) -> &'py crate::types::PyComplex {
-        crate::types::PyComplex::from_doubles(py, 0.0, 0.0)
+    fn __complex__<'py>(
+        &self,
+        py: crate::Python<'py>,
+    ) -> crate::Bound<'py, crate::types::PyComplex> {
+        crate::types::PyComplex::from_doubles_bound(py, 0.0, 0.0)
     }
 
     fn __int__(&self) -> u32 {
@@ -673,8 +676,11 @@ impl Dummy {
         slf
     }
 
-    fn __complex__<'py>(&self, py: crate::Python<'py>) -> &'py crate::types::PyComplex {
-        crate::types::PyComplex::from_doubles(py, 0.0, 0.0)
+    fn __complex__<'py>(
+        &self,
+        py: crate::Python<'py>,
+    ) -> crate::Bound<'py, crate::types::PyComplex> {
+        crate::types::PyComplex::from_doubles_bound(py, 0.0, 0.0)
     }
 
     fn __int__(&self) -> u32 {