pyo3-build-config: make InterpreterConfig public #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I think this needs to happen. Shall we go a little further and remove the I think to make this useful in practice you may also want |
PyOxidizer will want to create interpreter config files. Rather than reinvent the logic for reading/writing these files, I think it makes sense to consume the `pyo3-build-config` crate so we can use the `InterpreterConfig` type directly. But the symbol needs to be public to allow us to do that. And in order to allow direct construction, we need to make all the types referenced by its fields public as well.
indygreg
force-pushed
the
public-interpreter-config
branch
from
eb01281
to
62e1342
Compare
|
Yeah, we need to make all referenced fields public as well. I would have realized that if I actually tried to use this branch :) Good catch. I rebased and force pushed a change to expose the additional types. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyOxidizer will want to create interpreter config files. Rather
than reinvent the logic for reading/writing these files, I think
it makes sense to consume the
pyo3-build-configcrate so we canuse the
InterpreterConfigtype directly. But the symbol needsto be public to allow us to do that.
(Strictly speaking I could probably hack my way into getting an
instance of
InterpreterConfigviaget()and use that. But thatis exceptionally hacky.)