-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand on the C api definitions #2409
Conversation
12366d0
to
76f4494
Compare
Nice, these changes look along the right lines to me! It would be nice to add some tests for the inlined functions in methodobject.rs
TBH I think struct definitions should be checked carefully whether they're PyPy compatible, because we could get UB/crashes if they're wrong. For functions, the worst that happens is that we get a linker error if there's a PyPy gate missing. So I tend to be a bit lax with PyPy gates on functions, though in principle they all could have either a |
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
d3d29c2
to
5da3b97
Compare
I think that's all. I can't quite figure out how to squash them though. I suppose we can "squash and merge"? |
👍 looks good to me, I'll click squash & merge. Thanks! (Hopefully with this PR |
I'm not entirely sure whether I got the cfg's right. When do I need to add (or not add) a PyPy gate?