Use Python::with_gil in tests #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejrs
commented
Jul 19, 2022
| @@ -181,7 +181,7 @@ jobs: | |||
| run: | | |||
| set -x | |||
| cargo update -p indexmap --precise 1.6.2 | |||
| cargo update -p hashbrown:0.12.2 --precise 0.9.1 | |||
| cargo update -p hashbrown:0.12.3 --precise 0.9.1 | |||
There was a problem hiding this comment.
Uh, so does this need bumping every time hashbrown releases? 🤔
There was a problem hiding this comment.
Yes. In rust-numpy, I avoid this using Python scripting but that is not pretty either: https://github.com/PyO3/rust-numpy/blob/main/.github/workflows/ci.yml#L133-L143
There was a problem hiding this comment.
Doing it programatically makes sense; could potentially put that into the noxfile / xtask so we can just do nox -s set-mrsv-versions here?
There was a problem hiding this comment.
(We can leave this for a separate PR)
davidhewitt
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Thanks very much for doing this! I'd better get on and rebase #1788 to avoid people adding new acquire_gil tests!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just updates the tests - no actual changes.