Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export new dict views types #2590

Merged
merged 3 commits into from Aug 25, 2022
Merged

fix: export new dict views types #2590

merged 3 commits into from Aug 25, 2022

Conversation

PrettyWood
Copy link
Contributor

Thank you for v0.17.0, which adds #2358!
Unfortunately we can't use them directly since those new types are not exposed and getting them directly from dict doesn't work as well since dict module is private

If this is approved, could we add this in a v0.17.1 please?

@PrettyWood PrettyWood changed the title fix: export new dict types fix: export new dict views types Aug 24, 2022
@PrettyWood PrettyWood mentioned this pull request Aug 24, 2022
Merged
davidhewitt
davidhewitt reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, whoops! Could you please also add a CHANGELOG entry? Maybe the following:

## [Unreleased]

### Fixed

- Fix visibility of `PyDictItems`, `PyDictKeys`, and `PyDictValues` types added in PyO3 0.17.0.

src/types/mod.rs Outdated Show resolved Hide resolved
PrettyWood and others added 2 commits August 24, 2022 21:02
@PrettyWood @davidhewitt
fix exposed PyDictItems
1b7e39d 
Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
@PrettyWood
add changelog entry
e1af917
@PrettyWood
Copy link
Contributor Author

Thank you @davidhewitt for the review! Changes applied

davidhewitt
davidhewitt approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 👍

Yes will push out a 0.17.1, maybe with other fixes if we get any other bug reports.

@davidhewitt davidhewitt merged commit 611ecc1 into PyO3:main Aug 25, 2022
@PrettyWood PrettyWood deleted the export-new-dict-types branch August 27, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PrettyWood @davidhewitt