NonNull pointer for Py, PyObject #260
Conversation
| } | ||
|
|
||
| /// Creates a `PyObject` instance for the given FFI pointer. | ||
| /// Panics if the pointer is `null`. | ||
| /// Undefined behavior if the pointer is invalid. | ||
| #[inline] | ||
| pub unsafe fn from_owned_ptr_or_panic(py: Python, ptr: *mut ffi::PyObject) -> PyObject { | ||
| pub unsafe fn from_owned_ptr_or_panic(_py: Python, ptr: *mut ffi::PyObject) -> PyObject { |
There was a problem hiding this comment.
Removing the unused _py arg leads to pyfunction macro breaking in a way I'm not familiar enough to address now.
There was a problem hiding this comment.
It's because you need to have the GIL acquired or the python c api calls done by panic_after_error and the debug version of from_owned_ptr are undefined behavior.
src/instance.rs
Outdated
| @@ -212,12 +213,14 @@ where | |||
|
|
|||
| /// Specialization workaround | |||
| trait AsPyRefDispatch<T: PyTypeInfo>: ToPyPointer { | |||
| #[inline] | |||
|
Great, thanks! |
|
In general I like the idea of using Do have benchmarks for the inline annotations? I'm reluctant to sprinkling |
|
I've replaced the I've removed the inlines rather than worry about it, except on |
|
Thank you, look good now! |
This feels marginally safer and the combination of NonNull and inlines yield a small performance improvement in a library I have.