Fix #240 #263
Merged
Fix #240 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pganssle
reviewed
Nov 10, 2018
| def test_tz_class_introspection(): | ||
| tzi = rdt.TzClass() | ||
|
|
||
| assert tzi.__class__ == rdt.TzClass | ||
| assert repr(tzi) == "TzClass()" | ||
| assert repr(tzi).startswith('<rustapi_module.datetime.TzClass object at') |
There was a problem hiding this comment.
Can we not define a custom repr for this to make this test pass?
Or is the problem not hit if you define a custom repr?
There was a problem hiding this comment.
Or is the problem not hit if you define a custom repr
I haven't tested it but I think so, since this segfault happens when creating class name string.
There was a problem hiding this comment.
Ah, good point, though I think the repr could be effectively:
def __repr__(self):
return "%s()" % self.__class__.__name__Your version seems fine, though.
There was a problem hiding this comment.
I'm going to take it as it because I want that change for 0.5.0, but feel free to change this into something different later
|
Thank you for tracking this down. This is a really import fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to python doc, Py_TPFLAGS_HEAPTYPE is set when the type object itself is allocated on the (python?) heap.
But currently it's set for all subclasses, though we always have pyclass' type object as a static variable.
This causes segfault in #240.
I'm sure current approach is wrong, but I'm not sure how we should distinct a type is a heaptype or not(Maybe we should extend current API to have
is_heapflag?).Anyway, I feel there's many points to be fixed around our current approach for type object and tp_flags.
cc: @pganssle, @konstin