ci: run pyo3-ffi-check using nox #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
nox-ffi-check
branch
from
a7a3527
to
4798818
Compare
|
bors r+ |
|
Build failed: |
davidhewitt
force-pushed
the
nox-ffi-check
branch
from
4798818
to
f8bc676
Compare
|
bors r+ |
|
Build failed: |
davidhewitt
force-pushed
the
nox-ffi-check
branch
from
f8bc676
to
f6a12a8
Compare
|
bors r+ |
|
Build failed: |
davidhewitt
force-pushed
the
nox-ffi-check
branch
from
f6a12a8
to
56d8480
Compare
|
bors r+ |
|
Build failed: |
1 similar comment
|
Build failed: |
|
bors r+ |
|
Build failed: |
davidhewitt
force-pushed
the
nox-ffi-check
branch
from
56d8480
to
0164769
Compare
|
bors r+ |
|
Build failed: |
davidhewitt
force-pushed
the
nox-ffi-check
branch
2 times, most recently
from
d0456b4
to
78c22a5
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 24, 2022
2784: Automatically generate `__text_signature__` for all functions r=davidhewitt a=davidhewitt This PR makes it so that PyO3 generates `__text_signature__` by default for all functions. It also introduces `#[pyo3(text_signature = false)]` to disable the built-in generation. There are a few limitations which we can improve later: - All default values are currently set to `...`. I think this is ok because `.pyi` files often do the same. Maybe for numbers, strings, `None` and `True`/`False` we could render these in a future PR. - No support for `#[new]` yet. Alternative design ideas: - Only autogenerate for methods with `#[pyo3(signature = (...))]` annotation. I started with this, and then decided it made sense to do it for everything. - Opt-out with `#[pyo3(text_signature = None)]`. This is slightly harder to parse in the macro, but matches the final result in Python better, so if this looks preferable to others, I can change from `text_signature = false` to `text_signature = None`. There's some small tidying up / refactoring to do before this merges (happy to take suggestions on this), however the general logic, design and docs are ready for review. 2813: ci: run pyo3-ffi-check using nox r=davidhewitt a=davidhewitt Makes it easier to run pyo3-ffi-check locally :) Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
|
Build failed (retrying...): |
|
Build failed: |
davidhewitt
force-pushed
the
nox-ffi-check
branch
3 times, most recently
from
7e7cd61
to
99d1253
Compare
davidhewitt
force-pushed
the
nox-ffi-check
branch
from
99d1253
to
87b6a9b
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to run pyo3-ffi-check locally :)