Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect: gate behind experimental-inspect feature #2882

Merged
merged 1 commit into from Jan 17, 2023

Conversation

davidhewitt
Copy link
Member

This is the last thing I want to do before preparing 0.18 release.

The pyo3::inspect functionality looks useful as a first step towards #2454. However, we don't actually make use of this anywhere within PyO3 yet (we could probably use it for better error messages). I think we also have open questions about the traits which I'd like to resolve before committing to these additional APIs. (For example, this PR adds IntoPy::type_output, which seems potentially misplaced to me, the type_output function probably wants to be on a non-generic trait e.g. ToPyObject or maybe #2316.)

As such, I propose putting these APIs behind an experimental-inspect feature gate for now, and invite users who find them useful to contribute a finished-off design.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jan 15, 2023
@davidhewitt
Copy link
Member Author

(Changelog skip just because I'll manually include this in the 0.18 release branch coming shortly, to simplify rebasing.)

@davidhewitt davidhewitt mentioned this pull request Jan 15, 2023
@davidhewitt
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 17, 2023

Build succeeded:

@bors bors bot merged commit 72c561c into PyO3:main Jan 17, 2023
bors bot added a commit that referenced this pull request Jan 17, 2023
2883: release: 0.18.0 r=davidhewitt a=davidhewitt

Release for 0.18.0

I propose to put this live on Tuesday, will merge #2882 and rebase first.

Closes #2785 

Co-authored-by: David Hewitt <1939362+davidhewitt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant