Improve default values for str, numbers and bool in text_signature
#3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messense
force-pushed
the
text-signature-lit
branch
from
235c637
to
911e0e3
Compare
messense
force-pushed
the
text-signature-lit
branch
from
911e0e3
to
79a70f3
Compare
davidhewitt
reviewed
Mar 16, 2023
| // has a default, just use ... for now | ||
| output.push_str("=..."); | ||
| output.push('='); | ||
| output.push_str(&self.default_value_for_parameter(parameter)); |
There was a problem hiding this comment.
So because self.default_value_for_parameter does a search of the arguments by name, this is O(n²), but only for small n, so it's probably fine.
I was planning to avoid that by storing the default expressions in self.python_signature, but that was harder with the deprecated args attribute still present.
There was a problem hiding this comment.
So because
self.default_value_for_parameterdoes a search of the arguments by name, this is O(n²), but only for small n, so it's probably fine.
Yeah, I think the same.
davidhewitt
approved these changes
Mar 25, 2023
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #2863