truncate leap seconds on chrono to datetime conversions
#3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2023
Closed
|
I split out #3469, please review that first. |
|
Also moved the warnings testing logic out into #3470. |
davidhewitt
force-pushed
the
truncate-leap-seconds
branch
from
2d2a527
to
0459532
Compare
|
Rebased; this now contains purely the behavioural changes plus updates to accompanying tests. |
|
If I don't hear reasons not to, I'll merge this on Friday so that I can work on a fix for #3266 without having masses of conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3424
As discussed in that issue, I decided to proceed to truncate leap-seconds and emit a warning when doing so.
Most the diff is adjustment to test code to adjust for the logic, check the warning is raised and also deal with increased strictness of when leap-seconds are allowed in
chrono0.4.31.