Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PyInterpreterConfig api #3502

Merged
merged 1 commit into from Oct 8, 2023
Merged

add PyInterpreterConfig api #3502

merged 1 commit into from Oct 8, 2023

Conversation

mejrs
Copy link
Member

@mejrs mejrs commented Oct 8, 2023

No description provided.

@mejrs mejrs force-pushed the interpreterapi branch 2 times, most recently from 0b72ac6 to 4b7ae5a Compare October 8, 2023 19:26
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think just one tiny correction needed, afterwards please merge! :)

Comment on lines 59 to 65
use_main_obmalloc: c_int,
allow_fork: c_int,
allow_exec: c_int,
allow_threads: c_int,
allow_daemon_threads: c_int,
check_multi_interp_extensions: c_int,
gil: c_int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields need to be pub I think:

Suggested change
use_main_obmalloc: c_int,
allow_fork: c_int,
allow_exec: c_int,
allow_threads: c_int,
allow_daemon_threads: c_int,
check_multi_interp_extensions: c_int,
gil: c_int,
pub use_main_obmalloc: c_int,
pub allow_fork: c_int,
pub allow_exec: c_int,
pub allow_threads: c_int,
pub allow_daemon_threads: c_int,
pub check_multi_interp_extensions: c_int,
pub gil: c_int,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

@mejrs mejrs enabled auto-merge October 8, 2023 20:39
@mejrs mejrs added this pull request to the merge queue Oct 8, 2023
Merged via the queue into PyO3:main with commit 36b4a79 Oct 8, 2023
32 checks passed
@mejrs mejrs deleted the interpreterapi branch October 8, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants