Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement PyListMethods #3680

Merged
merged 3 commits into from
Dec 21, 2023
Merged

implement PyListMethods #3680

merged 3 commits into from
Dec 21, 2023

Conversation

davidhewitt
Copy link
Member

Split from #3606

Follows the same patterns we've seen in #3675 for the gil-ref iterator to wrap the new iterator. I think this is again extremely mechanical.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Dec 20, 2023
Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #3680 will not alter performance

Comparing davidhewitt:list2 (ee1272e) with main (7f626b2)

Summary

✅ 78 untouched benchmarks

src/types/list.rs Outdated Show resolved Hide resolved
src/instance.rs Outdated Show resolved Hide resolved
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit w.r.t. documentation, otherwise LGTM.

@davidhewitt
Copy link
Member Author

Thanks for all these reviews 🙏

I think my next step today is to write a high-level summary of the tasks remaining before I think we can release this API, so that we all have a sense of progress (and can coordinate picking up items in parallel if desired).

@davidhewitt davidhewitt added this pull request to the merge queue Dec 21, 2023
Merged via the queue into PyO3:main with commit 2788f4a Dec 21, 2023
37 checks passed
@davidhewitt davidhewitt deleted the list2 branch December 21, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants