Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partially revert changes to PyTzInfoAccess trait #3699

Merged
merged 1 commit into from
Dec 24, 2023
Merged

partially revert changes to PyTzInfoAccess trait #3699

merged 1 commit into from
Dec 24, 2023

Conversation

davidhewitt
Copy link
Member

Following the suggestion to deprecate-and-add-bound-variant, this partially reverts the modification to PyTzInfoAccess in #3679 to add get_tzinfo_bound.

adamreichold
adamreichold approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@adamreichold adamreichold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably also needs adjustment to the pytests as before.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Dec 24, 2023
@davidhewitt
Copy link
Member Author

I think I got them this time 😂

@davidhewitt davidhewitt added this pull request to the merge queue Dec 24, 2023
Merged via the queue into PyO3:main with commit 214ed29 Dec 24, 2023
37 of 38 checks passed
@davidhewitt davidhewitt deleted the tzinfo branch December 24, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamreichold adamreichold adamreichold approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidhewitt @adamreichold