Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate py.from_owned_ptr methods #3875

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Deprecate py.from_owned_ptr methods #3875

merged 2 commits into from
Feb 22, 2024

Conversation

LilyFoote
Copy link
Contributor

More tidy up for #3684.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 20, 2024 •
edited

CodSpeed Performance Report

Merging #3875 will not alter performance

Comparing LilyFoote:deprecate-from-owned-ptr (ef65874) with main (61bc02d)

🎉 Hooray! pytest-codspeed just leveled up to 2.2.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 67 untouched benchmarks

davidhewitt
davidhewitt reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One correction for the deprecation messages, and then a few suggestions of a little bit of extra tidy up...

src/conversion.rs Outdated Show resolved Hide resolved
src/types/slice.rs Outdated Show resolved Hide resolved
src/types/memoryview.rs Outdated Show resolved Hide resolved
src/types/bytearray.rs Outdated Show resolved Hide resolved
@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Feb 20, 2024
LilyFoote
LilyFoote commented Feb 20, 2024
View reviewed changes
src/types/string.rs Outdated Show resolved Hide resolved
@LilyFoote @davidhewitt
Refactor PyString.to_str
ef65874 
Co-authored-by: David Hewitt <mail@davidhewitt.dev>
davidhewitt
davidhewitt approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this one looks good to me 👍

src/types/complex.rs
self.py()
.from_owned_ptr(ffi::PyComplex_FromCComplex(ffi::_Py_c_neg(val)))
}
(-self.as_borrowed()).into_gil_ref()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidhewitt davidhewitt added this pull request to the merge queue Feb 22, 2024
Merged via the queue into PyO3:main with commit 5ddcd46 Feb 22, 2024
36 of 39 checks passed
@LilyFoote LilyFoote deleted the deprecate-from-owned-ptr branch February 22, 2024 09:22
@davidhewitt davidhewitt mentioned this pull request Feb 24, 2024
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Icxolu Icxolu Icxolu left review comments

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LilyFoote @davidhewitt @Icxolu