-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a safe API wrapping PyEval_SetProfile #4039
Draft
LilyFoote
wants to merge
15
commits into
PyO3:main
Choose a base branch
from
LilyFoote:set-profile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Jun 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98f3a5b - Browse repository at this point
Copy the full SHA 98f3a5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e49383 - Browse repository at this point
Copy the full SHA 1e49383View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d557f9 - Browse repository at this point
Copy the full SHA 8d557f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f924a - Browse repository at this point
Copy the full SHA e3f924aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9632bb9 - Browse repository at this point
Copy the full SHA 9632bb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eedbb34 - Browse repository at this point
Copy the full SHA eedbb34View commit details -
Configuration menu - View commit details
-
Copy full SHA for c48d218 - Browse repository at this point
Copy the full SHA c48d218View commit details -
Configuration menu - View commit details
-
Copy full SHA for c621bbb - Browse repository at this point
Copy the full SHA c621bbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d55c7f3 - Browse repository at this point
Copy the full SHA d55c7f3View commit details -
Avoid checking overhead in profile_callback
We can trust the types CPython provides to be correct.
Configuration menu - View commit details
-
Copy full SHA for 9f10f87 - Browse repository at this point
Copy the full SHA 9f10f87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82afd8e - Browse repository at this point
Copy the full SHA 82afd8eView commit details -
Rename register_profiler to setprofile
This matches the Python naming better.
Configuration menu - View commit details
-
Copy full SHA for e82b04b - Browse repository at this point
Copy the full SHA e82b04bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6d94a - Browse repository at this point
Copy the full SHA 0a6d94aView commit details -
`PyRefMut` can lead to problems when profiling a multithreaded Python program. Using `PyRef` and interior mutability is more robust.
Configuration menu - View commit details
-
Copy full SHA for 2e184e3 - Browse repository at this point
Copy the full SHA 2e184e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ae8ef4 - Browse repository at this point
Copy the full SHA 3ae8ef4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.