Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change PyAnyMethods::dir to be fallible #4100

Merged
merged 1 commit into from Apr 19, 2024
Merged

change PyAnyMethods::dir to be fallible #4100

merged 1 commit into from Apr 19, 2024

Conversation

davidhewitt
Copy link
Member

As orginally reported in pydantic/pydantic#9250

__dir__ is implemented as a magic method and therefore can be fallible, we should reflect this in PyAnyMethods::dir rather than panic.

@davidhewitt davidhewitt mentioned this pull request Apr 19, 2024
Closed
1 task
@davidhewitt davidhewitt added this pull request to the merge queue Apr 19, 2024
Merged via the queue into PyO3:main with commit 947b372 Apr 19, 2024
43 checks passed
@davidhewitt davidhewitt deleted the fallible-dir branch April 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyFoote LilyFoote LilyFoote approved these changes

@Icxolu Icxolu Icxolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidhewitt @LilyFoote @Icxolu