Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature gate APIs using into_gil_ref (Part 2) #4166

Merged
merged 1 commit into from May 9, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented May 9, 2024

Part of #3960, continuing #4160

This prepares for deprecation of as/into_gil_ref() (which are needed for proceeding with Python). This feature gates the PyAny gil-ref APIs and adjusts the rest to compile again.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label May 9, 2024
@Icxolu Icxolu force-pushed the deprecate/into-gil-ref-2 branch from 4f65a5c to 4584a69 Compare May 9, 2024 19:34
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with just one set of suggested tidy ups...

src/impl_/extract_argument.rs Outdated Show resolved Hide resolved
src/impl_/extract_argument.rs Outdated Show resolved Hide resolved
src/impl_/extract_argument.rs Outdated Show resolved Hide resolved
@Icxolu Icxolu force-pushed the deprecate/into-gil-ref-2 branch from 4584a69 to db232e8 Compare May 9, 2024 21:39
@Icxolu Icxolu enabled auto-merge May 9, 2024 21:40
@Icxolu Icxolu added this pull request to the merge queue May 9, 2024
Merged via the queue into PyO3:main with commit 21c0248 May 9, 2024
41 of 43 checks passed
@Icxolu Icxolu deleted the deprecate/into-gil-ref-2 branch May 9, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants