Rework pyo3 features to make unlimited api opt-in #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidhewitt I meant to push this up a while ago, but life got in the way. I'm hoping this is on the right track, but I did find it difficult to be sure my changes were correct - I think a mistake here just leads to testing the wrong combination of features that still passes rather than helpful test failures. |
|
Yes, especially with #2865 (comment) I think it makes it tricky to control what's actually being built. Is this ready for review? |
|
Yeah, a review would be helpful. I'll also rebase later today. |
|
👍 will do my best to find a moment to review at earliest opportunity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2865.