fix __dict__ on Python 3.9 with limited API
#4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icxolu
approved these changes
Jun 14, 2024
|
Thanks for the review, I'll try to address all points tonight 👍 |
Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in CI trying to merge #4194
It looks like we knew about this in test cases already; when I originally implemented
#[pyclass(dict)]forabi3in #1342 I set these test cases to be ignored.The problem is that
PyObject_GenericGetDictdoesn't exist in the limited API until Python 3.10. In this PR, instead of omitting the attribute we build a basic implementation ofPyObject_GenericGetDictwhich works for our need.