Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow #[pymethods] to use lifetime #461

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Conversation

kngwyu
Copy link
Member

@kngwyu kngwyu commented Apr 24, 2019

E.g., allow

fn method<'py>(py: Python<'py>) -> &'py PyList {...}

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #461 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   87.87%   87.83%   -0.04%     
==========================================
  Files          65       64       -1     
  Lines        3398     3388      -10     
==========================================
- Hits         2986     2976      -10     
  Misses        412      412
Impacted Files Coverage Δ
src/marshal.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5bf17f...5a63bdd. Read the comment docs.

Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you!

@kngwyu kngwyu merged commit be10800 into PyO3:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants