Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default implementation for PyGCProtocol #532

Merged
merged 5 commits into from
Jul 15, 2019

Conversation

Alexander-N
Copy link
Member

Implementations for these methods should always be provided. See #531

Implementations for these methods should always be provided. See PyO3#531
pganssle added a commit to pganssle/pyo3 that referenced this pull request Jul 14, 2019
src/class/gc.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #532   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files          65       65           
  Lines        3440     3440           
=======================================
  Hits         3012     3012           
  Misses        428      428
Impacted Files Coverage Δ
src/class/gc.rs 94.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a56fa...ec71dc6. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 14, 2019

Codecov Report

Merging #532 into master will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
- Coverage   87.68%   87.55%   -0.13%     
==========================================
  Files          65       65              
  Lines        3443     3440       -3     
==========================================
- Hits         3019     3012       -7     
- Misses        424      428       +4
Impacted Files Coverage Δ
src/class/gc.rs 94.11% <ø> (-0.48%) ⬇️
src/instance.rs 96.66% <0%> (-1.34%) ⬇️
src/err.rs 61.11% <0%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b0a02...9c961b4. Read the comment docs.

@konstin
Copy link
Member

konstin commented Jul 15, 2019

Thank you!

@konstin konstin merged commit 5ae014f into PyO3:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants