Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in FromPyObject for BigInt #630

Merged
merged 2 commits into from
Oct 19, 2019
Merged

Fix off-by-one error in FromPyObject for BigInt #630

merged 2 commits into from
Oct 19, 2019

Conversation

programmerjake
Copy link
Contributor

Fixes #629

@programmerjake
Copy link
Contributor Author

programmerjake commented Oct 15, 2019 •
edited
Loading

tests failing due to unrelated errors caused by pymodule interacting with latest nightly producing an out-of-range array index in doctests for guide/src/class.md.

@kngwyu
Copy link
Member

kngwyu commented Oct 15, 2019 •
edited
Loading

Thank you for such a quick fix.

kngwyu
kngwyu requested changes Oct 15, 2019
View reviewed changes
src/types/num.rs Outdated Show resolved Hide resolved
src/types/num.rs Outdated Show resolved Hide resolved
src/types/num.rs Outdated Show resolved Hide resolved
@kngwyu
Copy link
Member

kngwyu commented Oct 19, 2019

Thank you!

@kngwyu kngwyu merged commit 6997533 into PyO3:master Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OverflowError when converting python int to BigInt
2 participants
@programmerjake @kngwyu