Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subclass support #64

Merged
merged 1 commit into from Jul 27, 2017
Merged

subclass support #64

merged 1 commit into from Jul 27, 2017

Conversation

messense
Copy link
Member

Ref #15

@messense messense requested a review from fafhrd91 July 27, 2017 07:13
messense
messense commented Jul 27, 2017
View reviewed changes
pyo3cls/src/py_class.rs Outdated
@@ -440,6 +440,10 @@ fn parse_attribute(attr: String) -> (HashMap<&'static str, syn::Ident>,
flags.push(syn::Ident::from("_pyo3::typeob::PY_TYPE_FLAG_WEAKREF"));
continue
}
"basetype" => {
Copy link
Member Author

@messense messense Jul 27, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is a good name. Feels odd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree. maybe "subclass"?

fafhrd91
fafhrd91 reviewed Jul 27, 2017
View reviewed changes
guide/src/class.md Outdated
@@ -61,6 +61,7 @@ python object that can be collector `PyGCProtocol` trait has to be implemented.
* `weakref` - adds support for python weak references
* `base=xxx.YYY` - use custom base class. It is not possible to call constructor
of base class at the moment. `xxx.YYY`, `xxx` - module name, `YYY` class name.
* `basetype` - adds subclass support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe something like "python classes can inherit from this class", otherwise it is not clear

fafhrd91
fafhrd91 requested changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@fafhrd91 fafhrd91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add entry to CHANGELOG

@messense
Copy link
Member Author

Seem that some test cases are flaky.

@fafhrd91
Copy link
Contributor

Yes, ref count related tests are flaky because Rust runs multiple tests in parallel. I will fix later

@messense messense merged commit ebcd4f5 into PyO3:master Jul 27, 2017
@messense messense deleted the feature/subclass branch July 27, 2017 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fafhrd91 fafhrd91 fafhrd91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@messense @fafhrd91