Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derive for PyObjectSetAttrProtocol. #645

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

sebpuetz
Copy link
Contributor

PyObjectSetAttrProtocol doesn't define associated type Success.

Thank you for contributing to pyo3!

Here are some things you should check for submitting your pull request:

  • Run cargo fmt (This is checked by travis ci)
  • Run cargo clippy and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis)
  • If applicable, add an entry in the changelog.

Fixes #609

PyObjectSetAttrProtocol doesn't define associated type Success.
@kngwyu
Copy link
Member

kngwyu commented Oct 25, 2019

Good catch 👍 , thank you.

@kngwyu kngwyu merged commit f8e07b2 into PyO3:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing __setattr__ errors
2 participants