Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RustBin setuptools install #275

Merged
merged 1 commit into from Jul 30, 2022
Merged

Fix RustBin setuptools install #275

merged 1 commit into from Jul 30, 2022

Conversation

jameshilliard
Copy link
Contributor

Fixes: #274

@jameshilliard jameshilliard force-pushed the install-scripts-rustbin branch 2 times, most recently from 420aca1 to 6d1d368 Compare July 30, 2022 02:52
messense
messense reviewed Jul 30, 2022
View reviewed changes
Copy link
Member

@messense messense left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think we should add a test case to ensure that it does not regress in the future, right now we only test with wheel.

https://github.com/PyO3/setuptools-rust/blob/main/examples/hello-world/noxfile.py

@jameshilliard jameshilliard force-pushed the install-scripts-rustbin branch 2 times, most recently from 87c0e99 to 84f1897 Compare July 30, 2022 03:58
@messense messense mentioned this pull request Jul 30, 2022
Closed
@jameshilliard jameshilliard force-pushed the install-scripts-rustbin branch 5 times, most recently from 7fea4a0 to f28f232 Compare July 30, 2022 04:36
@jameshilliard
Copy link
Contributor Author

Thanks, I think we should add a test case to ensure that it does not regress in the future, right now we only test with wheel.

Yeah, think I got the setuptools only install working in a test, along with an install exclusion filter so that setuptools doesn't also install scripts in places that don't make sense like:

venv/lib/python3.10/site-packages/maturin-0.13.0-py3.10-linux-x86_64.egg/maturin-0.13.0.data/scripts/maturin

messense
messense approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@messense messense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@messense messense merged commit 8ff92d1 into PyO3:main Jul 30, 2022
@jameshilliard jameshilliard deleted the install-scripts-rustbin branch July 30, 2022 05:14
@davidhewitt
Copy link
Member

👍 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RustBin doesn't get installed to correct scripts path with setup.py install
3 participants
@jameshilliard @davidhewitt @messense