Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow profile to be set by SETUPTOOLS_RUST_CARGO_PROFILE env variable #364

Merged
merged 1 commit into from
Oct 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
- Drop support for Python 3.7. [#357](https://github.com/PyO3/setuptools-rust/pull/357)
- Remove direct imports from `pkg_resources`. [#359](https://github.com/PyO3/setuptools-rust/pull/359)

### Added
- Add support for setting a custom cargo profile with the `SETUPTOOLS_RUST_CARGO_PROFILE` environment variable. [#364](https://github.com/PyO3/setuptools-rust/pull/364)

## 1.7.0 (2023-08-22)
### Packaging
- Remove direct imports from `distutils`. [#336](https://github.com/PyO3/setuptools-rust/pull/336)
Expand Down
20 changes: 16 additions & 4 deletions setuptools_rust/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,10 @@ def _cargo_args(
if target_triple is not None:
args.extend(["--target", target_triple])

if release:
profile = ext.get_cargo_profile()
if not profile:
args.append("--release")
ext_profile = ext.get_cargo_profile()
env_profile = os.getenv("SETUPTOOLS_RUST_CARGO_PROFILE")
if release and not ext_profile and not env_profile:
args.append("--release")

if quiet:
args.append("-q")
Expand All @@ -541,6 +541,18 @@ def _cargo_args(
if ext.args is not None:
args.extend(ext.args)

if env_profile:
if ext_profile:
args = [p for p in args if not p.startswith("--profile=")]
while True:
try:
index = args.index("--profile")
del args[index : index + 2]
except ValueError:
break

args.extend(["--profile", env_profile])

if ext.cargo_manifest_args is not None:
args.extend(ext.cargo_manifest_args)

Expand Down