[Reviewed] PV horizontal tracking #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest we use 'dual' tracking instead of 'vh', as it's a bit more clear.
The equations don't need to be changed. The 'surface_orientation['slope']' for horizontal tracking (where the slope changes through the day) is calculated in the Orientation.py script.
Also update assertion error
Pv horizontal tracking
PV horizontal tracking
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #293 +/- ##
==========================================
+ Coverage 72.80% 73.06% +0.26%
==========================================
Files 19 19
Lines 1625 1641 +16
Branches 277 279 +2
==========================================
+ Hits 1183 1199 +16
Misses 366 366
Partials 76 76
☔ View full report in Codecov by Sentry. |
FabianHofmann
approved these changes
May 2, 2023
|
Great @FabianHofmann! Let's tackle it later. The graphic and average capacity factors for May already illustrate the idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #255 but with one additional commit.
Cleaned-up example notebook.