Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-ascii character from source file #193

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

koen-vg
Copy link
Contributor

@koen-vg koen-vg commented Nov 22, 2021

Unfortunately Snakemake for now reads files using the default OS file encoding, which may not be UTF-8. Therefore, it is best to be conservative and only use ascii in source files for now.

This actually crashed the pypsa-eur-sec snakemake workflow for me on a server where the file in question was attempted decoded in ascii.

This fix will be redundant once snakemake/snakemake#1146 gets merged, but it may still be a little while until that filters down to everyone.

Unfortunately Snakemake for now reads files using the default OS file
encoding, which may not be UTF-8. Therefore, it is best to be
conservative and only use ascii in source files for now.
@fneum
Copy link
Member

fneum commented Nov 22, 2021

Many thanks! I encountered the same error recently but didn't get to identifying the non-ascii character yet.

@fneum fneum merged commit f93ec5a into PyPSA:master Nov 22, 2021
@koen-vg koen-vg deleted the fix-non-ascii branch November 22, 2021 13:19
@koen-vg
Copy link
Contributor Author

koen-vg commented Nov 22, 2021

Thanks for the quick response!

LukasFrankenQ pushed a commit to LukasFrankenQ/pypsa-eur-sec that referenced this pull request Apr 12, 2023
* add option to use custom clustermaps from data folder

* adapt default config to custom busmap

* input file from Snakefile

* adapt input description

* add option to use custom clustermaps from data folder

* adapt default config to custom busmap

* input file from Snakefile

* adapt input description

* Snakefile: custom_busmap in cluster_network input is now csv

* cluster_network: custom_busmap is now read as csv file, adaptions of description

* simplify_network: adapt descriptions

* configfiles: add cutom_clustermaps switch

* unify clustarmap and busmap names

* unify clustermap and busmap names

* test/config: unify clustermap and busmap names

* cluster_network: make clustering_for_n_clusters compatible with simplify_network

* simplify_network: make compatible with changes in cluster_network.py

* Update scripts/cluster_network.py

* Update scripts/simplify_network.py

* Update scripts/simplify_network.py

* Update scripts/cluster_network.py

* Update scripts/cluster_network.py

* cluster_network: move custom_busmap flag to enable; simplify names

* cluster_network: move custom_busmap flag to enable; simplify names

* custom_busmap: add documentation

* cluster_network: add default for custom_busmap for compatibility with old configs

* cluster_network: add default for custom_busmap for compatibility with old configs

Co-authored-by: martha.frysztacki <eb5194@iai-esm003.iai.kit.edu>
Co-authored-by: Fabian Neumann <fabian.neumann@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants