Skip to content

Commit

Permalink
Merge pull request #1075 from koen-vg/time-agg-fix
Browse files Browse the repository at this point in the history
Minor bugfixes for new time aggregation implementation
  • Loading branch information
fneum committed May 21, 2024
2 parents 1fff76b + 2a6dcc4 commit fd7dcb2
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions scripts/prepare_sector_network.py
Original file line number Diff line number Diff line change
Expand Up @@ -3634,15 +3634,13 @@ def set_temporal_aggregation(n, resolution, snapshot_weightings):
logger.info("Use every %s snapshot as representative", sn)
n.set_snapshots(n.snapshots[::sn])
n.snapshot_weightings *= sn
return n
else:
# Otherwise, use the provided snapshots
snapshot_weightings = pd.read_csv(
snapshot_weightings, index_col=0, parse_dates=True
)

n.set_snapshots(snapshot_weightings.index)
n.snapshot_weightings = snapshot_weightings

# Define a series used for aggregation, mapping each hour in
# n.snapshots to the closest previous timestep in
# snapshot_weightings.index
Expand All @@ -3656,16 +3654,23 @@ def set_temporal_aggregation(n, resolution, snapshot_weightings):
.map(lambda i: snapshot_weightings.index[i])
)

m = n.copy(with_time=False)
m.set_snapshots(snapshot_weightings.index)
m.snapshot_weightings = snapshot_weightings

# Aggregation all time-varying data.
for c in n.iterate_components():
pnl = getattr(m, c.list_name + "_t")
for k, df in c.pnl.items():
if not df.empty:
if c.list_name == "stores" and k == "e_max_pu":
c.pnl[k] = df.groupby(aggregation_map).min()
pnl[k] = df.groupby(aggregation_map).min()
elif c.list_name == "stores" and k == "e_min_pu":
c.pnl[k] = df.groupby(aggregation_map).max()
pnl[k] = df.groupby(aggregation_map).max()
else:
c.pnl[k] = df.groupby(aggregation_map).mean()
pnl[k] = df.groupby(aggregation_map).mean()

return m


def lossy_bidirectional_links(n, carrier, efficiencies={}):
Expand Down Expand Up @@ -3818,7 +3823,7 @@ def lossy_bidirectional_links(n, carrier, efficiencies={}):
if options["allam_cycle"]:
add_allam(n, costs)

set_temporal_aggregation(
n = set_temporal_aggregation(
n, snakemake.params.time_resolution, snakemake.input.snapshot_weightings
)

Expand Down

0 comments on commit fd7dcb2

Please sign in to comment.