Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_DC_cluster_issue #1067

Merged
merged 1 commit into from
May 19, 2024
Merged

fix_DC_cluster_issue #1067

merged 1 commit into from
May 19, 2024

Conversation

p-glaum
Copy link
Contributor

@p-glaum p-glaum commented May 17, 2024

Closes #996

Changes proposed in this Pull Request

This PR fixes the bug described in #996. It guarantees that new links defined in links_tyndp.csv are only connected to AC buses. Before, this caused an error because we obtained a "meshed" DC grid in the model, which was not cleaned in the simplify_network script and led to wrong clustering.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@tgi-climact
Copy link
Contributor

Thanks for the PR @p-glaum . When I looked up into the issue, I saw that filtering only AC buses resulted in different coordinates for the tyndp links. Have you checked this ? Is this a problem ? Thanks

@p-glaum
Copy link
Contributor Author

p-glaum commented May 17, 2024

In my opinion this should not make a difference, because so far as I know, in links_tyndp the geo coordinates are just taken roughly from Open Street Maps. Additionally, the exact location of the TYNDP links isn't clear anyway. We want to switch to OSM for the base network anyway, and then we will also have some new functionalities which can better handle those cases from #996. For example, if there is a new DC link for an offshore node which currently does not exist in the base network, base_network.py will add a new bus at the given location.

Have you found any big differences? Because usually, we aggregate the network anyway and do not solve it in high resolution.

@tgi-climact
Copy link
Contributor

No big differences founded. I was just sharing my observations and related questions. Glad to read that it should not be a problem. Then the fix is quite simple.

@fneum fneum merged commit cf8ee69 into master May 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clustering problem seemingly caused by addition of new TYNDP projects
3 participants